Adding nonce attrs to external scripts where their host hasnt been defined in the CSP already #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…fined in the CSP already
Codecov Report
@@ Coverage Diff @@ ## master-v3 #27 +/- ## ========================================== + Coverage 91.56% 93% +1.43% ========================================== Files 2 2 Lines 83 100 +17 Branches 11 16 +5 ========================================== + Hits 76 93 +17 Misses 6 6 Partials 1 1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@ ## master-v3 #27 +/- ## ============================================= + Coverage 91.56% 93.91% +2.34% ============================================= Files 2 2 Lines 83 115 +32 Branches 11 21 +10 ============================================= + Hits 76 108 +32 Misses 6 6 Partials 1 1
Continue to review full report at Codecov.
|
… if the domain has been whitelisted. Also validating static sources
AnujRNair added a commit that referenced this pull request Jan 30, 2019
* Allow different policies on individual HtmlWebpackPlugin instances (#26) * renaming disableCspPlugin to cspPlugin.enabled to be more inline with the main enabled setting * Adding the option to allow individual policies on a specific html webpack plugin instance * Updating README to reflect the new changes * Adding nonce attrs to external scripts where their host hasnt been defined in the CSP already (#27) * Adding nonce attrs to external scripts where their host hasnt been defined in the CSP already * Making sure that nonces are included when strict-dynamic is set, even if the domain has been whitelisted. Also validating static sources * If plugin is disabled, we should not modify the html at all (#28) * If plugin is disabled, we should not modify the html at all * Updating readme to reflect new recommendation of not including a blank meta tag - it will be added for us * 3.0.0-beta.1 * Fine Grain control for hashes and nonces (#29) * Changing devAllowUnsafe to be more fine-grain by allowing the dev to decide when to allow hashes and nonces * Updating readme to reflect new options * 3.0.0-beta.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Nonce attributes will now be added to external scripts and styles whos hostnames haven't been defined in the CSP policy already. If, however, you add your public path to your CSP policy, a nonce won't be added for that specific script tag.
Before merging this, we should check to see if
strict-dynamicexists in the policy - if it does, we will still need to generate nonce ids for all external assets, even if their host has been allowed in the CSP policyRequirements (place an
xin each[ ])