Allow different policies on individual HtmlWebpackPlugin instances #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Starting the new Jest tests * Moving all tests to jest * Updating npm run scripts to use jest instead of individual modules * Upgrading all packages * Adding back codecov which was unintentionally removed
… the main enabled setting
…pack plugin instance
Codecov Report
@@ Coverage Diff @@ ## master-v3 #26 +/- ## ============================================= - Coverage 97.32% 91.56% -5.76% ============================================= Files 2 2 Lines 187 83 -104 Branches 14 11 -3 ============================================= - Hits 182 76 -106 - Misses 5 6 +1 - Partials 0 1 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@ ## master-v3 #26 +/- ## ============================================ - Coverage 97.32% 93.5% -3.82% ============================================ Files 2 2 Lines 187 77 -110 Branches 14 11 -3 ============================================ - Hits 182 72 -110 + Misses 5 4 -1 - Partials 0 1 +1
Continue to review full report at Codecov.
|
AnujRNair added a commit that referenced this pull request Jan 30, 2019
* Allow different policies on individual HtmlWebpackPlugin instances (#26) * renaming disableCspPlugin to cspPlugin.enabled to be more inline with the main enabled setting * Adding the option to allow individual policies on a specific html webpack plugin instance * Updating README to reflect the new changes * Adding nonce attrs to external scripts where their host hasnt been defined in the CSP already (#27) * Adding nonce attrs to external scripts where their host hasnt been defined in the CSP already * Making sure that nonces are included when strict-dynamic is set, even if the domain has been whitelisted. Also validating static sources * If plugin is disabled, we should not modify the html at all (#28) * If plugin is disabled, we should not modify the html at all * Updating readme to reflect new recommendation of not including a blank meta tag - it will be added for us * 3.0.0-beta.1 * Fine Grain control for hashes and nonces (#29) * Changing devAllowUnsafe to be more fine-grain by allowing the dev to decide when to allow hashes and nonces * Updating readme to reflect new options * 3.0.0-beta.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds functionality to allow the dev to specify individual CSPs on different HtmlWebpackPlugin instances. Full details on how to do so have been added to the readme.
Note: This change introduces a breaking change into the plugin, changing
disableCspPlugintocspPlugin.enabled- because of this, we will need a major version bump when this is publishedRequirements (place an
xin each[ ])