V6 #9
Closed
V6 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits November 19, 2016 13:01
| I just tried also! Looks great! |
justin808 reviewed Nov 19, 2016
| "expose-loader": "^0.7.1", | ||
| "imports-loader": "^0.6.5", | ||
| "react": "^0.14.8 || ^15.0.0", | ||
| "react-dom": "^0.14.8 || ^15.0.0", |
There was a problem hiding this comment.
@nostophilia Here's that 0.14.8 again.
justin808 reviewed Nov 19, 2016
| @@ -0,0 +1,45 @@ | |||
| { | |||
| "name": "react-webpack-rails-tutorial", | |||
There was a problem hiding this comment.
@nostophilia: We get these warnings:
npm WARN react-webpack-rails-tutorial@0.0.1 No description npm WARN react-webpack-rails-tutorial@0.0.1 No repository field. npm WARN react-webpack-rails-tutorial@0.0.1 No license field. npm WARN react-webpack-rails-tutorial@0.0.1 No repository field. npm WARN react-webpack-rails-tutorial@0.0.1 No license field. There was a problem hiding this comment.
I've added "private": true, under
"name": "react-webpack-rails-tutorial", "version": "0.0.1", pushed v7
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "name": "react-webpack-rails-tutorial", | |||
There was a problem hiding this comment.
@nostophilia: We get these warnings:
npm WARN react-webpack-rails-tutorial@0.0.1 No description npm WARN react-webpack-rails-tutorial@0.0.1 No repository field. npm WARN react-webpack-rails-tutorial@0.0.1 No license field. npm WARN react-webpack-rails-tutorial@0.0.1 No repository field. npm WARN react-webpack-rails-tutorial@0.0.1 No license field. justin808 reviewed Nov 19, 2016
| @@ -0,0 +1,3 @@ | |||
| <h1 class="alert alert-info this-works">Hello World</h1> | |||
There was a problem hiding this comment.
@nostophilia
There should be no class values on this line.
<h1>Hello World</h1> 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@justin808
And please notice that on your v5 justin808 branch the generator wasn't up-to-date. It's using a previous version with linter issues.