V5 justin808

[justin808]

@nostophilia PLEASE address the lint issues and push v6.

Use the linters from the 2nd commit in this branch.

➜ ~/shakacode/react-on-rails/tmp/test-new-redux-generation/client (v5-justin808) ✗ npm run eslint -- --fix ✹ [19:36:09] > react-webpack-rails-tutorial@0.0.1 eslint /Users/justin/shakacode/react-on-rails/tmp/test-new-redux-generation/client > eslint --ext .js,.jsx . "--fix" /Users/justin/shakacode/react-on-rails/tmp/test-new-redux-generation/client/app/bundles/HelloWorld/actions/helloWorldActionCreators.jsx 3:1 error Prefer default export import/prefer-default-export /Users/justin/shakacode/react-on-rails/tmp/test-new-redux-generation/client/app/bundles/HelloWorld/components/HelloWorldWidget.jsx 30:11 error Form controls using a label to identify them must be programmatically associated with the control using htmlFor jsx-a11y/label-has-for /Users/justin/shakacode/react-on-rails/tmp/test-new-redux-generation/client/app/bundles/HelloWorld/containers/HelloWorld.jsx 3:25 error Absolute imports should come before relative imports import/imports-first 4:36 error Absolute imports should come before relative imports import/imports-first 5:23 error Absolute imports should come before relative imports import/imports-first /Users/justin/shakacode/react-on-rails/tmp/test-new-redux-generation/client/app/bundles/HelloWorld/reducers/index.jsx 4:31 error '/Users/justin/shakacode/react-on-rails/tmp/test-new-redux-generation/client/app/bundles/HelloWorld/reducers/helloWorldReducer.jsx' imported multiple times import/no-duplicates 5:1 error './helloWorldReducer' import is duplicated no-duplicate-imports 5:53 error '/Users/justin/shakacode/react-on-rails/tmp/test-new-redux-generation/client/app/bundles/HelloWorld/reducers/helloWorldReducer.jsx' imported multiple times import/no-duplicates /Users/justin/shakacode/react-on-rails/tmp/test-new-redux-generation/client/app/bundles/HelloWorld/store/helloWorldStore.jsx 9:22 error '/Users/justin/shakacode/react-on-rails/tmp/test-new-redux-generation/client/app/bundles/HelloWorld/reducers/index.jsx' imported multiple times import/no-duplicates 10:1 error '../reducers' import is duplicated no-duplicate-imports 10:31 error '/Users/justin/shakacode/react-on-rails/tmp/test-new-redux-generation/client/app/bundles/HelloWorld/reducers/index.jsx' imported multiple times import/no-duplicates ✖ 11 problems (11 errors, 0 warnings) 

[mongjong59]

@justin808
looks like the react_on_rails gem used here wasn't updated with my branch (e.g. mirrorCreator, Immutable is still here)

I've used the linters from here, the latest commit should pass it.