Skip to content

Fix ci build failures #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 3, 2015
Merged

Fix ci build failures #166

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
552a0de
Edit .travis.yml and .eslintrc to address CI build failures
dylangrafmyre Dec 2, 2015
15fbc29
Update .travis.yml to install gcc-4.9
dylangrafmyre Dec 2, 2015
4922099
Remove global npm install, and set g++-4.9 package install
dylangrafmyre Dec 2, 2015
6cd3c64
Fix eslint plugin error
josiasds Dec 3, 2015
4ee6b03
Merge branch 'fix-eslint-plugin-error' into fix-ci-build-failures
josiasds Dec 3, 2015
dc7476f
Enable react/prop-types eslint rule
josiasds Dec 3, 2015
7fd2552
Update .travis.yml to use new build platform in CI
dylangrafmyre Dec 3, 2015
ab2e32a
Fix apt repository within .travis.yml
dylangrafmyre Dec 3, 2015
bc07695
Disable eslint react/prop-types rule on commentsStore; revert previou…
josiasds Dec 3, 2015
25c6b55
Add comment to explain disabled eslint rule
josiasds Dec 3, 2015
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,21 @@ language:
- ruby
rvm:
- 2.2.3
before_install:
- sudo add-apt-repository ppa:ubuntu-toolchain-r/test -y
- sudo apt-get update -q
- sudo apt-get install g++-4.9 -y
env:
global:
- RAILS_ENV=test
- CXX=g++-4.9
install:
- bundle install
- nvm install 5.0
- nvm use 5.0
- npm install -g npm
- npm install
- cd client && npm run build:client
- npm run build:server
env:
- export RAILS_ENV=test
before_script:
- export DISPLAY=:99.0
- sh -e /etc/init.d/xvfb start
Expand Down
2 changes: 1 addition & 1 deletion client/.eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ rules:
react/no-did-update-set-state: 0
react/no-multi-comp: 2
react/no-unknown-property: 2
react/prop-types: 1
react/prop-types: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really useful validation. There's some regression in eslint that's failing this.

At the min, we need to doc why we're doing this change temporarily.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justin808 did you read the link in my above comment about the github issue from the eslint-plugin-react. Someone familiar with the react code should look at this and see if anything new in the code has triggered this issue? Or is still a bug in the plugin. Maybe you folks can try another react-props eslint plugin?
react/react-in-jsx-scope: 2
react/require-extension: [1, { extensions: [.js, .jsx] }]
react/self-closing-comp: 2
Expand Down