Fix ci build failures #166
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@justin808, @robwise, @alexfedoseev
I was able to fix the failing Travis CI build with setting Travis to install package
g++-4.9.However, I fixed the failing Codeship build by setting
react/prop-types: 0within.eslintrc.This was the build fail issue:
And referenced here in the issues for
eslint-plugin-react:jsx-eslint/eslint-plugin-react#9
I am sure you will not want to have this rule continually ignored; therefore, someone will need to address the issue in the code?
Thanks,
Dylan