Skip to content

Uses "read-from-string" to parse the input as a lisp list #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2019
Merged

Uses "read-from-string" to parse the input as a lisp list #23

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6616da
Uses "read-from-string" to parse the input as a list
weslleymberg Mar 4, 2019
72cea2b
Removes "trim-paren"
weslleymberg Mar 4, 2019
8523ef4
Removes call to unexistent "trim-paren"
weslleymberg Mar 4, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions web/webapp.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,10 @@

(defun parse-string (string)
"Translate string to a list expression"
(mapcar (lambda (x)
(intern (string-upcase x) :lisp-inference))
(str:words string)))
(if (and (str:starts-with-p "(" string)
(str:ends-with-p ")" string))
(read-from-string string)
(read-from-string (str:concat "(" string ")"))))

(defun trim-paren (string)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

poderia remover essa função?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adicionei o commit pra remover.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ótimo! Agora precisamos remover a funcall dela no método render para o tipo truth-table
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aqui

lisp-inference/web/webapp.lisp

Line 82 in 72cea2b

:placeholder (trim-paren (prop table)))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!
(string-trim '(#\( #\)) string))
Expand Down