Skip to content

Conversation

@weslleymberg
Copy link
Contributor

An step foward on issue #18

web/webapp.lisp Outdated
(read-from-string string)
(read-from-string (str:concat "(" string ")"))))

(defun trim-paren (string)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

poderia remover essa função?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adicionei o commit pra remover.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ótimo! Agora precisamos remover a funcall dela no método render para o tipo truth-table

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aqui

:placeholder (trim-paren (prop table)))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

(:input :type "text"
:name "prop"
:placeholder (trim-paren (prop table)))
:placeholder (prop table))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelente!

Copy link
Owner

@ryukinix ryukinix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As alterações estão ótimas para mim! Obrigado. Isso já vai ajudar bastante! Depois tentamos pegar os casos de borda.

@ryukinix ryukinix merged commit 0216fc3 into ryukinix:master Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants