Skip to content

Conversation

@cuviper
Copy link
Member

@cuviper cuviper commented Aug 25, 2025

This internal crate explicitly separates itself from the rustc
workspace, but it is needed for ./x test clippy to work, including its
dependencies when building from a vendored rustc-src tarball.

This internal crate explicitly separates itself from the `rustc` workspace, but it is needed for `./x test clippy` to work, including its dependencies when building from a vendored `rustc-src` tarball.
@rustbot
Copy link
Collaborator

rustbot commented Aug 25, 2025

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 25, 2025
@cuviper
Copy link
Member Author

cuviper commented Aug 25, 2025

I encountered these missing dependencies when building 1.90-beta in Fedora, so it would be nice to have this backported too.

@rustbot label beta-nominated

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 25, 2025
@Kobzol
Copy link
Member

Kobzol commented Aug 26, 2025

Makes sense.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 26, 2025

📌 Commit c73d7ae has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2025
bors added a commit that referenced this pull request Aug 26, 2025
Rollup of 11 pull requests Successful merges: - #144373 (remove deprecated Error::description in impls) - #144551 (Add aarch64_be-unknown-linux-musl target) - #145076 (Add new Tier-3 target: riscv64a23-unknown-linux-gnu) - #145481 (Add parentheses for closure when suggesting calling closure) - #145596 (Losslessly optimize PNG files) - #145615 (Fix doc of `std::os::windows::io::BorrowedSocket::borrow_raw`) - #145841 (Always build miri for the host in `x run miri`) - #145861 (bootstrap: vendor `clippy_test_deps` too) - #145863 (formatting_options: Make all methods `const`) - #145867 (cg_llvm: Assert that LLVM range-attribute values don't exceed 128 bits) - #145875 (Make bootstrap command caching opt-in) r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit 20a3e45 into rust-lang:master Aug 26, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 26, 2025
rust-timer added a commit that referenced this pull request Aug 26, 2025
Rollup merge of #145861 - cuviper:vendor-clippy, r=Kobzol bootstrap: vendor `clippy_test_deps` too This internal crate explicitly separates itself from the `rustc` workspace, but it is needed for `./x test clippy` to work, including its dependencies when building from a vendored `rustc-src` tarball.
@jieyouxu
Copy link
Member

jieyouxu commented Sep 9, 2025

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 9, 2025
@cuviper cuviper mentioned this pull request Sep 9, 2025
@cuviper cuviper modified the milestones: 1.91.0, 1.90.0 Sep 9, 2025
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 9, 2025
bors added a commit that referenced this pull request Sep 10, 2025
[beta] backports - Rust build fails on OpenBSD after using file_lock feature #145511 - Revert suggestions for missing methods in tuples #145765 - When determining if a trait has no entries for the purposes of omitting vptrs from subtrait vtables, consider its transitive supertraits' entries, instead of just its own entries. #145807 - Ship LLVM tools for the correct target when cross-compiling #145763 - bootstrap: vendor `clippy_test_deps` too #145861 r? cuviper
bors added a commit that referenced this pull request Sep 10, 2025
[beta] backports - Rust build fails on OpenBSD after using file_lock feature #145511 - Revert suggestions for missing methods in tuples #145765 - When determining if a trait has no entries for the purposes of omitting vptrs from subtrait vtables, consider its transitive supertraits' entries, instead of just its own entries. #145807 - Ship LLVM tools for the correct target when cross-compiling #145763 - bootstrap: vendor `clippy_test_deps` too #145861 r? cuviper
@cuviper cuviper deleted the vendor-clippy branch December 17, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-bootstrap-vendoring beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

5 participants