Cleanup LangString::parse #138535
Merged
Cleanup LangString::parse #138535
+41 −44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Flatten some `if`s into match patterns Use `str::strip_prefix` instead of `starts_with`+indexing Avoid redundant tests for `extra.is_some()`
| r? @notriddle rustbot has assigned @notriddle. Use |
rustbot added S-waiting-on-review 
| @bors r+ rollup |
bors added S-waiting-on-bors Kobzol added a commit to Kobzol/rust that referenced this pull request Mar 21, 2025
…arse-cleanup, r=notriddle Cleanup `LangString::parse` Flatten some `if`s into match patterns Use `str::strip_prefix` instead of `starts_with`+indexing Avoid redundant tests for `extra.is_some()`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 21, 2025
…arse-cleanup, r=notriddle Cleanup `LangString::parse` Flatten some `if`s into match patterns Use `str::strip_prefix` instead of `starts_with`+indexing Avoid redundant tests for `extra.is_some()`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 21, 2025
…arse-cleanup, r=notriddle Cleanup `LangString::parse` Flatten some `if`s into match patterns Use `str::strip_prefix` instead of `starts_with`+indexing Avoid redundant tests for `extra.is_some()`
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 22, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#136769 (Provide optional `Read`/`Write` methods for stdio) - rust-lang#138410 (Couple mir building cleanups) - rust-lang#138490 (Forward `stream_position` in `Arc<File>` as well) - rust-lang#138535 (Cleanup `LangString::parse`) - rust-lang#138536 (stable_mir: Add `MutMirVisitor`) - rust-lang#138673 (Fix build failure on Trusty) - rust-lang#138750 (Make `crate_hash` not iterate over `hir_crate` owners anymore) - rust-lang#138763 (jsondocck: Replace `jsonpath_lib` with `jsonpath-rust`) r? `@ghost` `@rustbot` modify labels: rollup
tgross35 added a commit to tgross35/rust that referenced this pull request Mar 22, 2025
…arse-cleanup, r=notriddle Cleanup `LangString::parse` Flatten some `if`s into match patterns Use `str::strip_prefix` instead of `starts_with`+indexing Avoid redundant tests for `extra.is_some()`
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 22, 2025
Rollup of 10 pull requests Successful merges: - rust-lang#137736 (Don't attempt to export compiler-builtins symbols from rust dylibs) - rust-lang#138236 (uefi: Add OwnedEvent abstraction) - rust-lang#138321 ([bootstrap] Distribute split debuginfo if present) - rust-lang#138410 (Couple mir building cleanups) - rust-lang#138490 (Forward `stream_position` in `Arc<File>` as well) - rust-lang#138535 (Cleanup `LangString::parse`) - rust-lang#138536 (stable_mir: Add `MutMirVisitor`) - rust-lang#138580 (resolve: Avoid some unstable iteration 2) - rust-lang#138601 (add FCW to warn about wasm ABI transition) - rust-lang#138631 (Update test for SGX now implementing `read_buf`) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 22, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#138410 (Couple mir building cleanups) - rust-lang#138490 (Forward `stream_position` in `Arc<File>` as well) - rust-lang#138535 (Cleanup `LangString::parse`) - rust-lang#138536 (stable_mir: Add `MutMirVisitor`) - rust-lang#138673 (Fix build failure on Trusty) - rust-lang#138750 (Make `crate_hash` not iterate over `hir_crate` owners anymore) - rust-lang#138763 (jsondocck: Replace `jsonpath_lib` with `jsonpath-rust`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 22, 2025
Rollup merge of rust-lang#138535 - yotamofek:pr/rustdoc/lang-string-parse-cleanup, r=notriddle Cleanup `LangString::parse` Flatten some `if`s into match patterns Use `str::strip_prefix` instead of `starts_with`+indexing Avoid redundant tests for `extra.is_some()`
This was referenced Mar 23, 2025
ehuss added a commit to ehuss/cargo that referenced this pull request Mar 25, 2025
This was broken due to a change in rust-lang/rust#138535. There is an approved PR in rust-lang/rust#138877 to fix it, but it may take a day or two for it to make its way to nightly. This should be reverted after it hits nightly.
ehuss added a commit to ehuss/cargo that referenced this pull request Mar 25, 2025
This was broken due to a change in rust-lang/rust#138535. There is an approved PR in rust-lang/rust#138877 to fix it, but it may take a day or two for it to make its way to nightly. This should be reverted after it hits nightly.
github-merge-queue bot pushed a commit to rust-lang/cargo that referenced this pull request Mar 25, 2025
This was broken due to a change in rust-lang/rust#138535. There is an approved PR in rust-lang/rust#138877 to fix it, but it may take a day or two for it to make its way to nightly. This should be reverted after it hits nightly.
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 2, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#138410 (Couple mir building cleanups) - rust-lang#138490 (Forward `stream_position` in `Arc<File>` as well) - rust-lang#138535 (Cleanup `LangString::parse`) - rust-lang#138536 (stable_mir: Add `MutMirVisitor`) - rust-lang#138673 (Fix build failure on Trusty) - rust-lang#138750 (Make `crate_hash` not iterate over `hir_crate` owners anymore) - rust-lang#138763 (jsondocck: Replace `jsonpath_lib` with `jsonpath-rust`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Flatten some
ifs into match patternsUse
str::strip_prefixinstead ofstarts_with+indexingAvoid redundant tests for
extra.is_some()