Skip to content

Conversation

@ehuss
Copy link
Contributor

@ehuss ehuss commented Mar 25, 2025

This was broken due to a change in
rust-lang/rust#138535. There is an approved PR in rust-lang/rust#138877 to fix it, but it may take a day or two for it to make its way to nightly. This should be reverted after it hits nightly.

@rustbot
Copy link
Collaborator

rustbot commented Mar 25, 2025

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 25, 2025
@weihanglo
Copy link
Member

The cfg stuff is annoying 😆. Should we just comment out the entire test temporarily?

This was broken due to a change in rust-lang/rust#138535. There is an approved PR in rust-lang/rust#138877 to fix it, but it may take a day or two for it to make its way to nightly. This should be reverted after it hits nightly.
@ehuss ehuss force-pushed the ignore-cargo_test_doctest_xcompile_ignores branch from f077af2 to 98a273f Compare March 25, 2025 15:02
@ehuss
Copy link
Contributor Author

ehuss commented Mar 25, 2025

Hm, forgot about that. I don't want to mess with the git history too much, so I just commented out the nightly part.

@weihanglo weihanglo enabled auto-merge March 25, 2025 15:17
@weihanglo weihanglo added this pull request to the merge queue Mar 25, 2025
Merged via the queue into rust-lang:master with commit e3b5faa Mar 25, 2025
21 checks passed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2025
Update cargo 10 commits in 307cbfda3119f06600e43cd38283f4a746fe1f8b..a6c604d1b8a2f2a8ff1f3ba6092f9fda42f4b7e9 2025-03-20 20:00:39 +0000 to 2025-03-26 18:11:00 +0000 - fix(package): update tracking issue for `--message-format` (rust-lang/cargo#15354) - docs(contrib): Expand the description of team meetings (rust-lang/cargo#15349) - feat(package): add unstable `--message-format` flag (rust-lang/cargo#15311) - feat(complete): Added completion for `--profile` (rust-lang/cargo#15308) - Uplift windows Cygwin DLL import libraries (rust-lang/cargo#15193) - do not pass cdylib link args to test (rust-lang/cargo#15317) - fix: revert the behavior checking lockfile's VCS status (rust-lang/cargo#15341) - Temporarily ignore cargo_test_doctest_xcompile_ignores (rust-lang/cargo#15348) - docs: fix typo in the "Shared cache" section (rust-lang/cargo#15346) - Fix some issues with future-incompat report generation (rust-lang/cargo#15345) r? ghost
@rustbot rustbot added this to the 1.87.0 milestone Mar 27, 2025
github-merge-queue bot pushed a commit that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

4 participants