Detect unused files in src/test/mir-opt and error on them in tidy. #103781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| r? @jyn514 (rustbot has picked a reviewer for you, use r? to override) |
rustbot added T-bootstrap 
| The new tidy check seems good to me 👍 @oli-obk can you or someone else on @rust-lang/wg-mir-opt confirm that just deleting these unused files is the right thing to do? Not sure if we should add a test that uses them or something. |
jyn514 added S-waiting-on-team | I had removed the test associated with these files in #100827 . There was a replacement test added at the time |
| @bors r+ rollup=iffy |
| 📌 Commit f5dc0758d0798a64932cd6c68a2b2f267e745b68 has been approved by It is now in the queue for this repository. |
bors added S-waiting-on-bors | ☔ The latest upstream changes (presumably #102950) made this pull request unmergeable. Please resolve the merge conflicts. |
bors added S-waiting-on-author 
JakobDegen force-pushed the mir-opt-tidy branch from f5dc075 to 17395b4 Compare | Rebased |
| @bors r+ |
bors added S-waiting-on-bors 
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2022
…earth Rollup of 8 pull requests Successful merges: - rust-lang#103072 (compiletest: set the dylib path when gathering target cfg) - rust-lang#103084 (Derive `Eq` and `Hash` for `ControlFlow`) - rust-lang#103575 (Change #[suggestion_*] attributes to use style="...") - rust-lang#103637 (Use stdio in UWP apps) - rust-lang#103638 (Add `multivalue` target feature to WASM target) - rust-lang#103781 (Detect unused files in `src/test/mir-opt` and error on them in tidy.) - rust-lang#103837 (Migrate sidebar-links-color GUI test to functions) - rust-lang#103839 (Print valid `--print` requests if request is invalid) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #97564 .
Determining which files are generated by a given mir opt test is somewhat difficult. Because of this, we extract the logic for doing it out into a common crate that both compiletest and tidy can depend on. This avoids making compiletest a dependency of tidy which would negatively impact compile times for tidy.
Testing for this is that it catches 5 files that violated this lint (and removes them).