Change #[suggestion_*] attributes to use style="..." #103575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Using the following command: find compiler/ -type f -name '*.rs' -exec perl -i -gpe \ 's/(#\[\w*suggestion)_(short|verbose|hidden)\(\s*(\S+,)?/\1(\3style = "\2",/g' \ '{}' + 
rustbot added A-translation 
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
rust-highfive added the S-waiting-on-review 
davidtwco approved these changes Nov 1, 2022
| Apologies for the delay in getting to this. @bors r+ |
bors added S-waiting-on-bors 
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2022
…earth Rollup of 8 pull requests Successful merges: - rust-lang#103072 (compiletest: set the dylib path when gathering target cfg) - rust-lang#103084 (Derive `Eq` and `Hash` for `ControlFlow`) - rust-lang#103575 (Change #[suggestion_*] attributes to use style="...") - rust-lang#103637 (Use stdio in UWP apps) - rust-lang#103638 (Add `multivalue` target feature to WASM target) - rust-lang#103781 (Detect unused files in `src/test/mir-opt` and error on them in tidy.) - rust-lang#103837 (Migrate sidebar-links-color GUI test to functions) - rust-lang#103839 (Print valid `--print` requests if request is invalid) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As discussed on Zulip, this changes
#[(multipart_)suggestion_{short,verbose,hidden}(...)]attributes to plain#[(multipart_)suggestion(...)]attributes with astyle = "{short,verbose,hidden}"parameter.It also adds a new style,
tool-only, that corresponds totool_only_span_suggestion/tool_only_multipart_suggestionand causes the suggestion to not be shown in human-readable output at all.Best reviewed commit-by-commit, there's a bit of noise in there.
cc #100717 @compiler-errors
r? @davidtwco