[Fix #1182] Fix a false positive for Rails/ActionControllerFlashBeforeRender #1528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
5hun-s changed the title 
koic reviewed Sep 14, 2025
Comment on lines 404 to 405
| messages = %w[fizz buzz fizzbuzz] | ||
| messages.each { flash[:alert] = _1 } |
There was a problem hiding this comment.
Metasyntactic variables are generally preferred to be foo, bar, and baz. Also, unless there is a specific reason, please use a regular block instead of numbered block parameter sytax.
Suggested change
| messages = %w[fizz buzz fizzbuzz] | |
| messages.each { flash[:alert] = _1 } | |
| messages = %w[foo bar baz] | |
| messages.each { |message| flash[:alert] = message } |
koic reviewed Sep 14, 2025
| expect_no_offenses(<<~RUBY) | ||
| class HomeController < ApplicationController | ||
| def create | ||
| messages = %w[fizz buzz fizzbuzz] |
There was a problem hiding this comment.
Suggested change
| messages = %w[fizz buzz fizzbuzz] | |
| messages = %w[foo bar baz] |
5hun-s force-pushed the fix_false_positive_for_rails_action_controller_flash_before_render branch from 73630a2 to 64fee7d Compare 
| @5hun-s Can you rebase with the latest master branch to resolve the CI failures? |
5hun-s force-pushed the fix_false_positive_for_rails_action_controller_flash_before_render branch from 64fee7d to 87e5bbf Compare 
| @koic I've done it. |
| Thanks! |
5hun-s deleted the fix_false_positive_for_rails_action_controller_flash_before_render branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #1182
This PR fixes a false positive for Rails/ActionControllerFlashBeforeRender when
flashis called in a block.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.