Merge pull request #1528 from 5hun-s/fix_false_positive_for_rails_action_controller_flash_before_render

[Fix #1182] Fix a false positive for Rails/ActionControllerFlashBeforeRender

Author: koic

changelog/fix_false_positive_for_rails_action_controller_flash_before_render.md

@@ -0,0 +1 @@
+* [#1182](https://github.com/rubocop/rubocop-rails/issues/1182): Fix a false positive for `Rails/ActionControllerFlashBeforeRender` when flash is called in a block. ([@5hun-s][])

lib/rubocop/cop/rails/action_controller_flash_before_render.rb

@@ -73,7 +73,7 @@ def followed_by_render?(flash_node)
  return false if use_redirect_to?(context)
 
  context = node
- elsif context.right_siblings.empty?
+ elsif context.right_siblings.empty? && !use_redirect_to?(context.parent)
  return true
  end
  context = context.right_siblings

spec/rubocop/cop/rails/action_controller_flash_before_render_spec.rb

@@ -395,4 +395,36 @@ def create
  RUBY
  end
  end
+
+ context 'when using `flash` in a one-line iteration block before `redirect_to`' do
+ it 'does not register an offense' do
+ expect_no_offenses(<<~RUBY)
+ class HomeController < ApplicationController
+ def create
+ messages = %w[foo bar baz]
+ messages.each { |message| flash[:alert] = message }
+
+ redirect_to :index
+ end
+ end
+ RUBY
+ end
+ end
+
+ context 'when using `flash` in a multi-line block before `redirect_to`' do
+ it 'does not register an offense' do
+ expect_no_offenses(<<~RUBY)
+ class HomeController < ApplicationController
+ def create
+ messages = %w[foo bar baz]
+ messages.each do |message|
+ flash[:alert] = message
+ end
+
+ redirect_to :index
+ end
+ end
+ RUBY
+ end
+ end
 end