Tweak find-by-memoization good example #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The current good section is quite a mouthful. That is partially the fault of Ruby, but it can be better: * Less indentation * Fewer lines of code * More concise This style is quite common: https://github.com/search?q=lang%3Aruby%20%2Freturn%20.*%20if%20defined%2F&type=code Tried searching for the other one but every search I try just times out. As for `instance_variable_defined?` vs `defined?`, it's just shorter.
| It seems that the early return with a guard clause makes the memoization intention clearer. |
koic added a commit to rubocop/rubocop-rails that referenced this pull request Aug 13, 2025
…moization` Follow-up to rubocop/rails-style-guide#368. Closes #1513.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The current good section is quite a mouthful.
That is partially the fault of Ruby, but it can be better:
This style is quite common:
https://github.com/search?q=lang%3Aruby%20%2Freturn%20.*%20if%20defined%2F&type=code
Tried searching for the other one but every search I try just times out.
As for
instance_variable_defined?vsdefined?, it's just shorter but does the same thing.I would like to change rubocop-rails autocorrect for this, so opening here first. rubocop/rubocop-rails#1513
cc @r7kamura if you have opinions here.