-
- Notifications
You must be signed in to change notification settings - Fork 285
Closed
Description
Is your feature request related to a problem? Please describe.
The unsafe auto correct for Rails/FindByOrAssignmentMemoization added too many lines to a couple of admittedly bloated classes.
Describe the solution you'd like
When running the new Rails/FindByOrAssignmentMemoization cop with the -A flag it will do the following:
Changes:
def product @product ||= Product.find_by(code: params[:code]) endTo:
def product if instance_variable_defined?(:@product) @product else @product = Product.find_by(code: params[:code]) end endTo save a few lines, I was wondering if the format could be changed to?
def product return @product if instance_variable_defined?(:@product) @product = Product.find_by(code: params[:code]) endAlanGabbianelli
Metadata
Metadata
Assignees
Labels
No labels