Skip to content

Conversation

@christophfroehlich
Copy link
Member

@christophfroehlich christophfroehlich commented Sep 16, 2025

In a recent PMC meeting we decided to deprecate the specializations for the sake of reducing duplicate code here in the repository.

Should we rename the package (can be done by adding a shim package with the old name and deprecation warnings) before adding another controller (twist_controller from #300)?

Slightly related to #157 (no need for controller specifications if we use standard Float64MultiArray message anyways)

@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.13%. Comparing base (f59b5a0) to head (4f9269c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #1913 +/- ## ======================================= Coverage 85.13% 85.13% ======================================= Files 144 144 Lines 13968 13968 Branches 1201 1201 ======================================= Hits 11891 11891 Misses 1670 1670 Partials 407 407 
Flag Coverage Δ
unittests 85.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
..._controllers/src/joint_group_effort_controller.cpp 62.50% <ø> (ø)
...ontrollers/src/joint_group_position_controller.cpp 66.66% <ø> (ø)
...ontrollers/src/joint_group_velocity_controller.cpp 62.50% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@christophfroehlich christophfroehlich added the check-prerelease-downstream Runs the pre-release workflow with 1st level downstream dependencies label Sep 16, 2025
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit 61b3bc6 into master Nov 19, 2025
17 of 18 checks passed
@christophfroehlich christophfroehlich deleted the deprecate/fwd_cmd_ctrl_specializations branch November 19, 2025 20:41
@github-project-automation github-project-automation bot moved this from Needs review to Done in Review triage Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

check-prerelease-downstream Runs the pre-release workflow with 1st level downstream dependencies

3 participants