Deprecate forward_command_controller specializations #1913
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In a recent PMC meeting we decided to deprecate the specializations for the sake of reducing duplicate code here in the repository.
Should we rename the package (can be done by adding a shim package with the old name and deprecation warnings) before adding another controller (twist_controller from #300)?
Slightly related to #157 (no need for controller specifications if we use standard Float64MultiArray message anyways)