Skip to content

Conversation

@aaltat
Copy link
Contributor

@aaltat aaltat commented Sep 8, 2017

Contains also rewording of some parts of the documentation

Fixes #888

Contains also rewording of some parts of the documentation Fixes robotframework#888
CONTRIBUTING.rst Outdated

- All new enhancements or changes should have a note telling when the
change was introduced. Often adding something like
``New in Selenium2Libray 1.8.`` is enough.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old library name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

CONTRIBUTING.rst Outdated

Keyword documentation can be easily created using `invoke`_ task::

inv generate-documentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer invoke generate-documentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to keyword_documentation

Chrome on Python 2.7, Python 3.3 and Python 3.6. Acceptance test are also run
by using Selenium 2.53.6 and latest available Selenium 3 version. The used
Robot Framework versions are: 2.8.7, 2.9.2 and 3.0.2.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add Firefox (after PR #890).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@aaltat aaltat merged commit 9bcd26b into robotframework:master Sep 14, 2017
@aaltat aaltat deleted the fix_CONTRIBUTING branch October 30, 2017 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants