Skip to content

Improve scrollIntoView #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Improve scrollIntoView #21

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c5dd6a
Correct querySelector binding by returning null
nojaf Nov 25, 2024
66127fe
Improve scrollIntoView
nojaf Nov 25, 2024
16df030
Update addEventlistener in Global.res
nojaf Nov 25, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Correct querySelector binding by returning null
  • Loading branch information
@nojaf
nojaf committed Nov 25, 2024
commit 6c5dd6a8e9b4c72f45a671f98ab0a431fe06fa17
2 changes: 1 addition & 1 deletion src/DOMAPI/Document.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ Returns the first element that is a descendant of node that matches selectors.
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/Document/querySelector)
*/
@send
external querySelector: (document, string) => element = "querySelector"
external querySelector: (document, string) => Null.t<element> = "querySelector"

/**
Returns all element descendants of node that match selectors.
Expand Down
2 changes: 1 addition & 1 deletion src/DOMAPI/DocumentFragment.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ Returns the first element that is a descendant of node that matches selectors.
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/DocumentFragment/querySelector)
*/
@send
external querySelector: (T.t, string) => element = "querySelector"
external querySelector: (T.t, string) => Null.t<element> = "querySelector"

/**
Returns all element descendants of node that match selectors.
Expand Down
2 changes: 1 addition & 1 deletion src/DOMAPI/Element.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ Returns the first element that is a descendant of node that matches selectors.
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/Document/querySelector)
*/
@send
external querySelector: (T.t, string) => element = "querySelector"
external querySelector: (T.t, string) => Null.t<element> = "querySelector"

/**
Returns all element descendants of node that match selectors.
Expand Down