Skip to content

Improve scrollIntoView #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Improve scrollIntoView #21

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c5dd6a
Correct querySelector binding by returning null
nojaf Nov 25, 2024
66127fe
Improve scrollIntoView
nojaf Nov 25, 2024
16df030
Update addEventlistener in Global.res
nojaf Nov 25, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update addEventlistener in Global.res
  • Loading branch information
@nojaf
nojaf committed Nov 25, 2024
commit 16df0308d79c20844d0bb6b7276ab4c7a5d8633e
14 changes: 7 additions & 7 deletions src/Global.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ The event listener is appended to target's event listener list and is not append
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/EventTarget/addEventListener)
*/
external addEventListener: (
~type_: string,
~type_: eventType,
~callback: eventListener<'event>,
~options: addEventListenerOptions=?,
) => unit = "addEventListener"
Expand All @@ -556,10 +556,10 @@ If an AbortSignal is passed for options's signal, then the event listener will b
The event listener is appended to target's event listener list and is not appended if it has the same type, callback, and capture.
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/EventTarget/addEventListener)
*/
external addEventListener2: (
~type_: string,
external addEventListener_useCapture: (
~type_: eventType,
~callback: eventListener<'event>,
~options: bool=?,
@as(json`true`) _,
) => unit = "addEventListener"

/**
Expand All @@ -576,10 +576,10 @@ external removeEventListener: (
Removes the event listener in target's event listener list with the same type, callback, and options.
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/EventTarget/removeEventListener)
*/
external removeEventListener2: (
~type_: string,
external removeEventListener_useCapture: (
~type_: eventType,
~callback: eventListener<'event>,
~options: bool=?,
@as(json`true`) _,
) => unit = "removeEventListener"

/**
Expand Down
Loading