Skip to content

Feat/cell editor #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: disable search
merged 11 commits into from
Sep 20, 2017
Merged

Feat/cell editor #61

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f1a0710
implement cell editor
AllenFang Sep 17, 2017
d8dbcb8
keyField shouldn't be editable
AllenFang Sep 17, 2017
2ecf6fe
add additional check to avoid some bugs
AllenFang Sep 17, 2017
97f3f2b
add jsdom for enzyme mount
AllenFang Sep 17, 2017
321d996
add some helpers class for enzyme mounting
AllenFang Sep 17, 2017
9bf57a1
add testing for cellEdit
AllenFang Sep 17, 2017
692b0a2
use npm instead
AllenFang Sep 17, 2017
246ff4c
add test for TableResolver
AllenFang Sep 19, 2017
77bb95a
table-layout: fixed; to fix the columns width when content of td changed
AllenFang Sep 19, 2017
1fad5dd
add stories for cell edit
AllenFang Sep 19, 2017
9f42714
add document for cellEdit
AllenFang Sep 20, 2017
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add additional check to avoid some bugs
  • Loading branch information
@AllenFang
AllenFang committed Sep 17, 2017
commit 2ecf6feaa7ebf6fa24899232776f635da7346d6b
4 changes: 4 additions & 0 deletions packages/react-bootstrap-table2/src/row.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,8 @@ Row.propTypes = {
columns: PropTypes.array.isRequired
};

Row.defaultProps = {
editable: true
};

export default Row;
2 changes: 1 addition & 1 deletion packages/react-bootstrap-table2/src/store/base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default class Store {

edit(rowId, dataField, newValue) {
const row = this.getRowByRowId(rowId);
_.set(row, dataField, newValue);
if (row) _.set(row, dataField, newValue);
}

get() {
Expand Down
5 changes: 3 additions & 2 deletions packages/react-bootstrap-table2/src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,13 @@ function get(target, field) {
return result;
}

function set(target, field, value) {
function set(target, field, value, safe = false) {
const pathArray = splitNested(field);
let level = 0;
pathArray.reduce((a, b) => {
level += 1;
if (typeof a[b] === 'undefined' && level !== pathArray.length) {
if (typeof a[b] === 'undefined') {
if (!safe) throw new Error(`${a}.${b} is undefined`);
a[b] = {};
return a[b];
}
Expand Down