Skip to content

Feat/cell editor #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: disable search
merged 11 commits into from
Sep 20, 2017
Merged

Feat/cell editor #61

merged 11 commits into from
Sep 20, 2017

Conversation

@AllenFang
Copy link
Member

#60

Big PR
@AllenFang AllenFang added this to the 0.1.0 milestone Sep 17, 2017
@AllenFang
Copy link
Member Author

AllenFang commented Sep 17, 2017 •
edited
Loading

@Chun-MingChen

I think you forgot to update the .travis.yml in #53 ?

Because this PR, I add jsdom and jsdom-global but still built fail on travis > https://travis-ci.org/react-bootstrap-table/react-bootstrap-table2/builds/276516432

You can trigger above job manually.

If yes, I'll update the travis config, thanks
@chunming-c
Copy link
Member

chunming-c commented Sep 18, 2017 •
edited
Loading

@AllenFang

These are document from yarn install --help

--pure-lockfile don't generate a lockfile --frozen-lockfile don't generate a lockfile and fail if an update is needed

Sorry for my careless, we do update .travis.yml with --pure-lockfile and it will fix this issue.

screen shot 2017-09-18 at 14 22 15
@chunming-c
Copy link
Member

Besides, There's one more thing that we've set postinstall to run lerna bootstrap automatically. However, it's unnecessary for CI mode. I fix this issue in my next PR to set new CLI command for travis needs.
@AllenFang
Copy link
Member Author

I'm already use npm as default in travis.yml in this PR, but you can change it in your PR
@chunming-c
Copy link
Member

Sure 💯
@AllenFang AllenFang changed the title [WIP] Feat/cell editor Feat/cell editor Sep 20, 2017
@AllenFang AllenFang merged commit f6eea2f into develop Sep 20, 2017
@AllenFang AllenFang deleted the feat/cell-editor branch September 21, 2017 02:10
@chunming-c chunming-c mentioned this pull request Oct 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development

2 participants

@AllenFang @chunming-c