Optimized string column sort (comparator + splitNested) #1627
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I've started experiencing really bad delay when changing page in my table whenever sorting by a string value column. I found the
splitNested
function to be the culprit. See 2 perf screenshots belowIt seems to be doing some useless actions, like joining on an array of 1 string and replacing text in multiple iterations.

I also did my best to optimize the regex without affecting functionality.
Here are some performance comparisons from JSBench.Me:
And the new real-world performance results:

Finally, I've used a better string comparison for very large array of strings. namely
Intl.Collator
instead oflocaleCompare
.See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/localeCompare#performance
(I haven't yet recorded performance comparison)