More efficient comparator for large array of string

See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/localeCompare#performance

Author: Avasam

packages/react-bootstrap-table2/src/store/sort.js

@@ -4,14 +4,13 @@
 import _ from '../utils';
 import Const from '../const';
 
+const collator = new Intl.Collator();
 function comparator(a, b) {
- let result;
  if (typeof b === 'string') {
- result = b.localeCompare(a);
+ return collator.compare(a, b);
  } else {
- result = a > b ? -1 : ((a < b) ? 1 : 0);
+ return a > b ? -1 : ((a < b) ? 1 : 0);
  }
- return result;
 }
 
 export const sort = (data, sortOrder, { dataField, sortFunc, sortValue }) => {

packages/react-bootstrap-table2/src/utils.js

@@ -56,8 +56,8 @@ function isEmptyObject(obj) {
  const hasOwnProperty = Object.prototype.hasOwnProperty;
  const keys = Object.keys(obj);
 
- for (let i = 0; i < keys.length; i += 1) {
- if (hasOwnProperty.call(obj, keys[i])) return false;
+ for (let key of keys) {
+ if (hasOwnProperty.call(obj, key)) return false;
  }
 
  return true;