Adds onKeyUp event to header for sort #1245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
AllenFang approved these changes Feb 9, 2020
| I'm using "react-bootstrap-table" in my application, and I have the issue that in a text filter on a column, when a user types in and presses enter, it will trigger the sort event, instead of the filter event - making it so that both the sort and filter event is triggered. Is there a way to make it so that pressing enter in the text field does not bubble the event? The screenshot shows the initial sort, and then what happens when I typed into a text filter and pressed enter |
| @tommica same issue |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Needed for keyboard navigation. Current functionality does not allow a user to sort with their keyboard,
Still doesn't call out ascending or descending order on a screen reader but I felt like this was a start.
#1238