Skip to content

Adds onKeyUp event to header for sort #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 9, 2020
Merged

Adds onKeyUp event to header for sort #1245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87caa37
Adds onKeyUp event to header for sort
Michael-Hanley Feb 8, 2020
20fb662
Adds tests for the KeyUp event on header
Michael-Hanley Feb 8, 2020
3d4c28a
fix linting issues
Michael-Hanley Feb 8, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/react-bootstrap-table2/src/header-cell.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,12 @@ class HeaderCell extends eventDelegater(React.Component) {

if (sort) {
const customClick = cellAttrs.onClick;
cellAttrs.onKeyUp = (e) => {
if (e.key === 'Enter') {
onSort(column);
if (_.isFunction(customClick)) customClick(e);
}
};
cellAttrs.onClick = (e) => {
onSort(column);
if (_.isFunction(customClick)) customClick(e);
Expand Down
14 changes: 14 additions & 0 deletions packages/react-bootstrap-table2/test/header-cell.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,11 +394,25 @@ describe('HeaderCell', () => {
expect(wrapper.find('th').prop('onClick')).toBeDefined();
});

it('should have onKeyUp event on header cell', () => {
expect(wrapper.find('th').prop('onKeyUp')).toBeDefined();
});

it('should trigger onSort callback when click on header cell', () => {
wrapper.find('th').simulate('click');
expect(onSortCallBack.callCount).toBe(1);
});

it('should trigger onSort callback when keyup Enter on header cell', () => {
wrapper.find('th').simulate('keyup', { key: 'Enter' });
expect(onSortCallBack.callCount).toBe(1);
});

it('should not trigger onSort callback when keyup key is not Enter on header cell', () => {
wrapper.find('th').simulate('keyup', { key: 'test-key' });
expect(onSortCallBack.callCount).toBe(0);
});

describe('and sorting prop is false', () => {
it('header should render SortSymbol as default', () => {
expect(wrapper.find(SortSymbol).length).toBe(1);
Expand Down