Skip to content

Conversation

seunomonije
Copy link
Contributor

Fixes #7695

WebGPU is the successor to WebGL, with libraries moving to support it. Cirq's TS environment hasn't installed the types library for WebGPU, causing package upgrades to fail.

Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.38%. Comparing base (72c728a) to head (60575ae).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@ ## main #7698 +/- ## ======================================= Coverage 99.38% 99.38% ======================================= Files 1089 1089 Lines 97550 97550 ======================================= Hits 96949 96949 Misses 601 601 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@seunomonije
Copy link
Contributor Author

This can be merged after #7697 to fix the dependabot issues

@seunomonije seunomonije marked this pull request as ready for review October 9, 2025 16:21
@seunomonije seunomonije requested review from a team and vtomole as code owners October 9, 2025 16:21
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seunomonije - I guess bundle files need to be rebuilt for this change?

@github-actions github-actions bot added size: L 250< lines changed <1000 and removed size: S 10< lines changed <50 labels Oct 10, 2025
@seunomonije
Copy link
Contributor Author

seunomonije commented Oct 10, 2025

@pavoljuhas yes, I think once everything gets in cleanly w/ less config changes things will settle. But it makes sense that the bundles would change as we update the packages

On my local machine I had Vite v7 installed in my environment while package.json had v5, it bundled differently, leading to the discrepancy. I rebuilt with check/npm install and committed the new bundle, and we're in the green. The same problem occurs in #7700

@pavoljuhas pavoljuhas added this pull request to the merge queue Oct 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2025
@pavoljuhas pavoljuhas added this pull request to the merge queue Oct 10, 2025
Merged via the queue into quantumlib:main with commit 770b5a6 Oct 10, 2025
35 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Oct 14, 2025
Fixes #7700 Dependabot wants to bump Vite from v5 to v7, but cannot rebuild the bundle file. This causes the `check/ts-build-current` CI test to fail. This PR introduces new "gold copy" bundle files built with Vite v7 that now match the upgraded packages, and manually bumps Vite to v7. Find the changes in the bundle file format from Vite [here](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md). Successor to #7698 --------- Co-authored-by: Pavol Juhas <juhas@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: L 250< lines changed <1000

2 participants