Skip to content

Conversation

seunomonije
Copy link
Contributor

@seunomonije seunomonije commented Oct 8, 2025

Fixes an issue found in #7687 where artifacts were not properly building with Vite. The appropriate CI output can be found here. See discussion in original PR for more details.

The issue stems from the fact that Vite does not allow handling multiple entry points from an array in configs, which is different than Webpack. A common alternative is to use separate config files for each entry point, but this PR leverages Vite's --mode flag to allow bundling from one file. Should the number of widgets in cirq-web grow, it may be worth looking at consolidating the widgets in one entry point, but that seems like overkill for now.

The large line count is due to how Vite bundles the TS, but the file size is still comparable to the old bundle files (501KB versus 503KB).

@github-actions github-actions bot added the size: XL lines changed >1000 label Oct 8, 2025
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.38%. Comparing base (e8e79bb) to head (81c946f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@ ## main #7697 +/- ## ======================================= Coverage 99.38% 99.38% ======================================= Files 1089 1089 Lines 97550 97550 ======================================= Hits 96949 96949 Misses 601 601 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@seunomonije seunomonije mentioned this pull request Oct 9, 2025
@seunomonije seunomonije marked this pull request as ready for review October 9, 2025 16:20
@seunomonije seunomonije requested review from a team and vtomole as code owners October 9, 2025 16:20
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@pavoljuhas pavoljuhas added this pull request to the merge queue Oct 10, 2025
Merged via the queue into quantumlib:main with commit 8137600 Oct 10, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: XL lines changed >1000

2 participants