Skip to content

Conversation

@Krilivye
Copy link
Contributor

@Krilivye Krilivye commented Oct 31, 2019

Will close #915

Seluj78
Seluj78 previously approved these changes Oct 31, 2019
Copy link
Collaborator

@Seluj78 Seluj78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour cette contribution 🎉

@Seluj78 Seluj78 dismissed their stale review October 31, 2019 14:42

Erreur , pas vu tout le fichier

Copy link
Collaborator

@Seluj78 Seluj78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci beaucoup pour cette contribution ! 🎉

Krilivye and others added 5 commits October 31, 2019 16:29
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
@Seluj78
Copy link
Collaborator

Seluj78 commented Nov 15, 2019

Hello @Krilivye ! Il faut que tu mette a jour les suggestions qui ont été faites ! :)

@Seluj78 Seluj78 added NEED REVIEWER This PR needs a reviewer :) and removed awaiting changes labels Nov 15, 2019
@Krilivye
Copy link
Contributor Author

Coucou @Seluj78 c'est bon pour toi?

@Seluj78
Copy link
Collaborator

Seluj78 commented Nov 18, 2019

Je vais relire ca 👌

Copy link
Collaborator

@deronnax deronnax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bon travail mais il y a quelques erreurs et quelques règles à appliquer (guillemets français), et quelques termes à trouver/choisir (stack frame)

Copy link
Collaborator

@Seluj78 Seluj78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est padpo... J'ai utilisé l'outil de @vpoulailleau 😉

 Super ce padpo! @vpoulailleau :). Merci pour le suivi @Seluj78 Merci aussi pour la relecture fine @deronnax je vais corriger les guillemets françaises ratées et "garbage" et "frame" Co-Authored-By: Mathieu Dupuy <deronnax@users.noreply.github.com> Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
Copy link
Contributor

@vpoulailleau vpoulailleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encore un coup de padpo !

padpo -p 920

@Seluj78 Seluj78 self-assigned this Dec 11, 2019
@Seluj78 Seluj78 removed the NEED REVIEWER This PR needs a reviewer :) label Dec 13, 2019
@Seluj78
Copy link
Collaborator

Seluj78 commented Dec 27, 2019

Hello @Krilivye, il faut que tu resolve les conversations finies et que tu check la CI 💪

Krilivye and others added 2 commits December 28, 2019 18:42
Co-Authored-By: Vincent Poulailleau <vpoulailleau@gmail.com>
@Krilivye Krilivye requested review from Seluj78 and deronnax December 28, 2019 18:39
@Krilivye
Copy link
Contributor Author

Krilivye commented Jan 9, 2020

Good pour moi :) @Seluj78

Copy link
Collaborator

@Seluj78 Seluj78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besoin de ré approve, je me suis trompé de bouton

@Seluj78 Seluj78 dismissed deronnax’s stale review February 4, 2020 10:33

Ok pour merge

@Seluj78 Seluj78 merged commit 6c4d056 into python:3.8 Feb 4, 2020
@Seluj78
Copy link
Collaborator

Seluj78 commented Feb 4, 2020

Merci pour cette PR 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants