Skip to content

[3.9] bpo-44145: Release the GIL around HMAC_Update. (GH-26157) #26188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2021
Merged

[3.9] bpo-44145: Release the GIL around HMAC_Update. (GH-26157) #26188

merged 1 commit into from
May 17, 2021

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 17, 2021 •
edited
Loading

It was always meant to be released for parallelization.
This now matches the other similar code in the module.

Thanks michaelforney for noticing!
(cherry picked from commit c10392e)

Co-authored-by: Gregory P. Smith greg@krypto.org

https://bugs.python.org/issue44145

Automerge-Triggered-By: GH:gpshead
@gpshead @miss-islington
bpo-44145: Release the GIL around HMAC_Update. (pythonGH-26157)
3b38d89 
It was always meant to be released for parallelization. This now matches the other similar code in the module. Thanks michaelforney for noticing! (cherry picked from commit c10392e) Co-authored-by: Gregory P. Smith <greg@krypto.org>
@miss-islington miss-islington requested a review from tiran as a code owner May 17, 2021 07:35
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error performance Performance or resource usage labels May 17, 2021
@bedevere-bot bedevere-bot mentioned this pull request May 17, 2021
Merged
@miss-islington
Copy link
Contributor Author

@gpshead: Status check is done, and it's a success ✅ .
@miss-islington
Copy link
Contributor Author

@miss-islington: Status check is done, and it's a success ✅ .
@miss-islington miss-islington merged commit 2057ce8 into python:3.9 May 17, 2021
@miss-islington miss-islington deleted the backport-c10392e-3.9 branch May 17, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Performance or resource usage type-bug An unexpected behavior, bug, or error

4 participants

@miss-islington @gpshead @the-knights-who-say-ni @bedevere-bot