bpo-44145: Release the GIL around HMAC_Update. #26157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
It was always meant to be released for parallelization. Thanks michaelforney for noticing.
gpshead added type-bug 
| Is github having issues? |
Yes GH actions seems to have problems: https://www.githubstatus.com/incidents/zbpwygxwb3gw |
| Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 17, 2021
It was always meant to be released for parallelization. This now matches the other similar code in the module. Thanks michaelforney for noticing! (cherry picked from commit c10392e) Co-authored-by: Gregory P. Smith <greg@krypto.org>
| GH-26187 is a backport of this pull request to the 3.10 branch. |
bedevere-bot removed needs backport to 3.10 | GH-26188 is a backport of this pull request to the 3.9 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 17, 2021
It was always meant to be released for parallelization. This now matches the other similar code in the module. Thanks michaelforney for noticing! (cherry picked from commit c10392e) Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington added a commit that referenced this pull request May 17, 2021
stratakis pushed a commit to stratakis/cpython that referenced this pull request Aug 5, 2021
It was always meant to be released for parallelization. This now matches the other similar code in the module. Thanks michaelforney for noticing! (cherry picked from commit c10392e) Co-authored-by: Gregory P. Smith <greg@krypto.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It was always meant to be released for parallelization.
Thanks michaelforney for noticing.
https://bugs.python.org/issue44145
Automerge-Triggered-By: GH:gpshead