[3.12] gh-112618: Make Annotated cache typed (#112619) #112628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
AlexWaygood requested review from JelleZijlstra and gvanrossum as code owners 
JelleZijlstra approved these changes Dec 3, 2023
| Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
| GH-112633 is a backport of this pull request to the 3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 3, 2023
…ythonGH-112628) (cherry picked from commit 2a378ca) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a manual backport of #112619. The fix has to be a little different in the 3.12 branch (since the implementation of
Annotatedis pretty different in the 3.12 branch), so if somebody else could take a quick look, I'd appreciate it :)typing.get_type_hintsCan Return Incorrect Type for Annotated Metadata #112618