Skip to content

gh-112618: Make Annotated cache typed #112619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 2, 2023
Merged

gh-112618: Make Annotated cache typed #112619

merged 9 commits into from
Dec 2, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Dec 2, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 2, 2023
Closed
sobolevn
sobolevn commented Dec 2, 2023
View reviewed changes
AlexWaygood
AlexWaygood reviewed Dec 2, 2023
View reviewed changes
AlexWaygood
AlexWaygood reviewed Dec 2, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice fix!
sobolevn and others added 3 commits December 2, 2023 15:58
AlexWaygood
AlexWaygood reviewed Dec 2, 2023
View reviewed changes
AlexWaygood
AlexWaygood reviewed Dec 2, 2023
View reviewed changes
sobolevn and others added 2 commits December 2, 2023 17:48
@sobolevn @AlexWaygood
Apply suggestions from code review
b83154b 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AlexWaygood
fix syntaxerror
5025f1c
AlexWaygood
AlexWaygood approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! Will hold off merging for a bit in case @JelleZijlstra has any objections, though :)
@AlexWaygood AlexWaygood merged commit a35a305 into python:main Dec 2, 2023
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
@miss-islington-app
Copy link

Sorry, @sobolevn and @AlexWaygood, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a35a30509820f956d6feeaa0dbf42e9ca82c12bb 3.12
@miss-islington-app
Copy link

Sorry, @sobolevn and @AlexWaygood, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a35a30509820f956d6feeaa0dbf42e9ca82c12bb 3.11
@AlexWaygood AlexWaygood mentioned this pull request Dec 2, 2023
Merged
@bedevere-app
Copy link

bedevere-app bot commented Dec 2, 2023

GH-112628 is a backport of this pull request to the 3.12 branch.
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 2, 2023
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Dec 2, 2023
@AlexWaygood
[3.12] pythongh-112618: Make Annotated cache typed (python#112619)
f5c1a10
@AlexWaygood AlexWaygood removed the needs backport to 3.11 only security fixes label Dec 2, 2023
@AlexWaygood
Copy link
Member

AlexWaygood commented Dec 2, 2023 •
edited
Loading

I've removed the "needs backport to 3.11" label from this PR, since it'll be easier to backport #112628 (which is the 3.12 backport) to 3.11 after that one's merged.
AlexWaygood added a commit that referenced this pull request Dec 3, 2023
@AlexWaygood
[3.12] gh-112618: Make Annotated cache typed (#112619) (#112628)
2a378ca
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 3, 2023
@AlexWaygood @miss-islington
[3.12] pythongh-112618: Make Annotated cache typed (pythonGH-112619) (p…
229e18d 
…ythonGH-112628) (cherry picked from commit 2a378ca) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request Dec 3, 2023
@miss-islington @AlexWaygood
[3.11] [3.12] gh-112618: Make Annotated cache typed (GH-112619) (GH-1…
db53770 
…12628) (#112633) [3.12] gh-112618: Make Annotated cache typed (GH-112619) (GH-112628) (cherry picked from commit 2a378ca) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @AlexWaygood @aisk
pythongh-112618: Make Annotated cache typed (python#112619)
ca2e49c 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @AlexWaygood @Glyphack
pythongh-112618: Make Annotated cache typed (python#112619)
aae749f 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic-typing

3 participants

@sobolevn @AlexWaygood @JelleZijlstra