This repository was archived by the owner on Apr 11, 2025. It is now read-only.
Speedup as in https://github.com/camelot-dev/camelot/issues/161 #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Speedup as in camelot-dev#161
For reference: numpy/numpy#16160
Seems still actual in 2024. My results:
import timeit print(timeit.timeit('np.isclose(0.5, 0, atol=1e-4)', 'import numpy as np', number=10000)) # 0.2664242945611477 print(timeit.timeit('math.isclose(0.5, 0, abs_tol=1e-4)', 'import math', number=10000)) # 0.001325499266386032Once ready, prefer to squash and merge.
More performance gains could potentially be realized. But let's do that in a separate PR.
atlanhq/camelot#427