This repository was archived by the owner on Apr 11, 2025. It is now read-only.
Refactor method Table.set_edges for readability #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
From all close points stored in `i`, `j` or `k` only the first one was used therefore the new function `find_close_point` only returns the first match if any. Similar code is hoisted out of loops and branches and the `while` loops are more clearly expressed with `for` loops.
Collaborator
| Thanks for this PR. |
`math.isclose()` is much faster than `np.isclose()` when comparing numbers. ``` >>> import timeit >>> print(timeit.timeit('np.isclose(0.5, 0, atol=1e-4)', 'import numpy as np', number=10000)) 0.06490494299941929 >>> print(timeit.timeit('math.isclose(0.5, 0, abs_tol=1e-4)', 'import math', number=10000)) 0.0034116959996026708 ``` Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I'm opening the merge request here too, as this repo is the active fork.
From all close points stored in
i,jorkonly the first one was used therefore the new functionfind_close_pointonly returns the first match if any.Similar code is hoisted out of loops and branches and the
whileloops are more clearly expressed withforloops.