ProgressBarCounter delayed removal #974
Conversation
Store the stop_time in order to track how long it took for the event to complete not how long the ProgressBarCounter has been around.
Remove_when_done accepts bool or int. Bool does as before where the counter is removed upon done or remains indefinitely. Int will cause counter to be removed only after that many seconds have passed.
| Can you explain a bit why exactly this feature would be good to have? (It sounds like a very specific use case, and in that case, it shouldn't be in prompt_toolkit itself, but we should expose the APIs to make it possible to build this on top.) |
| I have developed some relatively complex progress bars that contain a lot of information. For example, I have one example that does bulk downloads of files and upon downloading run some tests/post download process. In another example, I'm running a bulk SVN to Git migration where after cloning the SVN repo additional processing is done to clean up the repo prior to pushing. In other words, both of these processes contains a lot of different information. And when a process succeeds (or fails) I want to have an opportunity to inspect the bar prior to the bar being removed - hence a delayed remove. I can agree that this feature could be better implemented as some kind of callable - that way it could be a conditional remove (e.g. only keep the last 5 bars or a time delay removal). |
| closing in favor of #1025 |
2 participants
@jonathanslenders - this is dependant on #950