Added stop_time to ProgressBarCounter #950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jonathanslenders requested changes Sep 26, 2019
added 2 commits September 27, 2019 12:16
Store the stop_time in order to track how long it took for the event to complete not how long the ProgressBarCounter has been around.
kenodegard force-pushed the progressbar.stop-time branch from 124d58a to 8f777a3 Compare 
| Thanks @njalerikson! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When using ProgressBars it makes sense for elapsed time to stop incrementing once the counter in question finishes.