More 2.0 fixes #618
Closed
More 2.0 fixes #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Several places in the code assume history objects have the strings attribute (and that it's a list). We could add strings as an abstractproperty on the abc, but then every history class would have to define strings as a property, which would generally require using a getter and a setter. I'm not sure if we want that level of complication, so I haven't done it here.
Codecov Report
@@ Coverage Diff @@ ## 2.0 #618 +/- ## ========================================== - Coverage 70.91% 70.91% -0.01% ========================================== Files 131 131 Lines 12161 12163 +2 ========================================== + Hits 8624 8625 +1 - Misses 3537 3538 +1
Continue to review full report at Codecov.
|
| Thanks! This makes sense, but I think there is more to fix here. The Xonsh people have also been looking at lazy history loading. I have to think about how to support that. I think maybe in general this API can be improved. I'm actually also not such a fan anymore of the use of |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since you're cherrypicking, a new branch. Just one commit so far. I don't know if there will be more.