2.0 don't need to access member string #554
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`history` is already iteratable.
randy3k changed the title stringstring 
jonathanslenders force-pushed the 2.0 branch from 258d75f to 1a11668 Compare jonathanslenders force-pushed the 2.0 branch 3 times, most recently from bb017a8 to fc0d3b2 Compare | bump @jonathanslenders |
| This makes sense, but I'm not 100% sure yet. Possibly I'll have to redesign the API for the history. Some people asked for asynchronous loading of the history. I'm not yet sure how to make this work. |
Closed
| It's also used in DynamicHistory. |
| Closing this. The history has been refactored now. Feel free to open a new pull request if you think something is missing. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
historyis already "gettable".