Skip to content

Conversation

cristiangreco
Copy link
Contributor

@cristiangreco cristiangreco commented Sep 23, 2025

0.18.0 / 2025-09-25

* [FEATURE] Add `stat_progress_vacuum` collector by @ianbibby * [FEATURE] Add `buffercache_summary` collector by @sfc-gh-pnuttall * [FEATURE] `stat_statements`: export query itself together with `queryId` by @Delorien84 * [ENHANCEMENT] Update Go version by @SuperQ * [ENHANCEMENT] Improve error handling for `Server.Scrape` by @BoweFlex * [ENHANCEMENT] `stat_user_tables`: record table-only size bytes in addition to the total size bytes by @Sticksman * [ENHANCEMENT] (chore) Fix a typo and use `slices.Contains` by @cristiangreco * [ENHANCEMENT] Update mixin to latest changes from `grafana/postgres_exporter` by @cristiangreco, @gaantunes, @v-zhuravlev and @mshahzeb * [ENHANCEMENT] Exclude the metrics fetching session's data from pg_stat_activity by @kmoppel * [BUGFIX] Ensure database connections are always closed by @cristiangreco and @dehaansa Signed-off-by: Cristian Greco <cristian@regolo.cc>
Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we release a version, I think we need to look into this - seems like others have found this to be a bug #1185 (review)

Co-authored-by: Joe Adams <github@joeadams.io> Signed-off-by: Cristian Greco <cristian@regolo.cc>
@cristiangreco
Copy link
Contributor Author

Before we release a version, I think we need to look into this - seems like others have found this to be a bug #1185 (review)

That PR is merged and included in the changelog. Do you mean that there's a bug introduced by that PR? Or that we should scan the code to find other cases like that?

@sysadmind
Copy link
Contributor

Sorry, I should have been more explicit. I believe that #1185 fixed a problem, however introduced a new bug. There is a reference to that PR from planetscale's repo where they reverted it. planetscale#7

Taking a closer look, the problem is a semicolon in the middle of the query. I just opened #1197 to fix it. I can't believe I missed that on the first review.

@cristiangreco cristiangreco mentioned this pull request Sep 25, 2025
Signed-off-by: Cristian Greco <cristian@regolo.cc>
@cristiangreco cristiangreco force-pushed the cristian/prepare-0.18.0 branch from 7e0ccff to 64a77bc Compare September 25, 2025 14:08
Signed-off-by: Cristian Greco <cristian@regolo.cc>
Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cristiangreco cristiangreco merged commit e62fe08 into master Sep 25, 2025
11 checks passed
@cristiangreco cristiangreco deleted the cristian/prepare-0.18.0 branch September 25, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants