Skip to content

Add a collector for pg_buffercache_summary. #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 19, 2025
Merged

Add a collector for pg_buffercache_summary. #1165

merged 7 commits into from
Jun 19, 2025

Conversation

sfc-gh-pnuttall
Copy link
Contributor

@sfc-gh-pnuttall sfc-gh-pnuttall commented Jun 3, 2025 •
edited by SuperQ
Loading

  • Add a collector for pg_buffercache_summary()
  • Requires PostgreSQL >= 16.
@sfc-gh-pnuttall
Add a collector for pg_buffercache.
2abb5c9 
We use this code in production in a internal fork. We would like to push it upstream. Default it to off, because it requires an extension to be loaded. Signed-off-by: Peter Nuttall <peter.nuttall@snowflake.com>
SuperQ
SuperQ reviewed Jun 18, 2025
View reviewed changes
@sfc-gh-pnuttall @SuperQ
Update collector/pg_buffercache.go
6014965 
Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: Peter Nuttall <peter.nuttall@snowflake.com>
SuperQ
SuperQ reviewed Jun 18, 2025
View reviewed changes
@sfc-gh-pnuttall
Rename s/pg_buffercache/pg_buffercache_summary/.
64f002f 
Signed-off-by: Peter Nuttall <peter.nuttall@snowflake.com>
@sfc-gh-pnuttall
Merge branch 'bufcache' of github.com:Snowflake-Labs/postgres_exporte…
93a7548 
…r into bufcache Signed-off-by: Peter Nuttall <peter.nuttall@snowflake.com>
SuperQ
SuperQ reviewed Jun 18, 2025
View reviewed changes
SuperQ
SuperQ reviewed Jun 18, 2025
View reviewed changes
sfc-gh-pnuttall and others added 2 commits June 18, 2025 18:14
@sfc-gh-pnuttall @SuperQ
Update collector/pg_buffercache_summary.go
aa004f6 
Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: Peter Nuttall <peter.nuttall@snowflake.com>
@sfc-gh-pnuttall
Move gaugeInt32 into collector.go.
6e53796 
Signed-off-by: Peter Nuttall <peter.nuttall@snowflake.com>
SuperQ
SuperQ reviewed Jun 18, 2025
View reviewed changes
@sfc-gh-pnuttall
copyright
62bcb12 
Signed-off-by: Peter Nuttall <peter.nuttall@snowflake.com>
SuperQ
SuperQ approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the helper as-is.

I have a couple ideas on adding a type handling wrapper around prometheus.NewDesc() that would help with the boilerplate null value checks.
@SuperQ SuperQ changed the title Add a collector for pg_buffercache. Add a collector for pg_buffercache_summary. Jun 19, 2025
@SuperQ SuperQ merged commit d8ba628 into prometheus-community:master Jun 19, 2025
11 checks passed
@cristiangreco cristiangreco mentioned this pull request Sep 25, 2025
Merged
@github-actions github-actions bot mentioned this pull request Sep 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@sfc-gh-pnuttall @SuperQ @sysadmind