Add a test case that includes a field

[yiming-tang-cs]

#129

[khatchad]

Is this test case different than the other tests that return INCONSISTENT_POSSIBLE_EXECUTION_MODES?

[khatchad]

In other words, do we already have tests with fields?

[khatchad]

Let's make this a passing test as previously requested. To do so, remove the call to parallel().

[yiming-tang-cs]

Just remove parallel()?

[yiming-tang-cs]

In other words, do we already have tests with fields?

No. They are different.
The test case below returns INCONSISTENT_POSSIBLE_EXECUTION_MODES, but it does not include a field.

package p; import java.util.HashSet; import java.util.stream.*; import edu.cuny.hunter.streamrefactoring.annotations.*; class A {	Stream<Object> m() {	Stream<Object> stream = new HashSet<>().stream().parallel();	return stream;	}	void n(Stream<Object> s) {	s.distinct().count();	}	@EntryPoint	public void main(String[] args) {	n(m());	} } 

[khatchad]

Yes. On Dec 21, 2017 4:49 PM, Grace Tang <notifications@github.com> wrote: @saledouble commented on this pull request.

________________________________ In edu.cuny.hunter.streamrefactoring.tests/resources/ConvertStreamToParallel/testField/in/A.java<#135 (comment)>:

@@ -0,0 +1,22 @@

+package p; + +import java.util.HashSet; +import java.util.stream.*; + +import edu.cuny.hunter.streamrefactoring.annotations.*; + +class A { + + Stream<Object> stream; + + void m() { + stream = new HashSet<>().stream().parallel(); Just remove parallel()? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub<#135 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AB9DP7mKQ89Bs2yBRbcvF9gxClitE5Emks5tCtJwgaJpZM4RKHkv>.