Skip to content

Add a test case that includes a field #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add a test case that includes a field #134

wants to merge 3 commits into from

Conversation

@yiming-tang-cs
Copy link
Contributor

@yiming-tang-cs yiming-tang-cs commented Dec 20, 2017

@khatchad
Copy link
Member

khatchad commented Dec 20, 2017 •
edited
Loading

@saledouble Add test case for what? Please make the title more specific.
@yiming-tang-cs yiming-tang-cs changed the title Add test case Add a test case that includes a field Dec 20, 2017
@yiming-tang-cs
Copy link
Contributor Author

yiming-tang-cs commented Dec 20, 2017

Add test case for what?

Sorry.
khatchad
khatchad requested changes Dec 21, 2017
View reviewed changes
Copy link
Member

@khatchad khatchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this case is testing functionality we are already testing, i.e., #98. Can we make this a passing case? For example, could you have n() first call m() prior to calling any methods on the field?
@yiming-tang-cs
Copy link
Contributor Author

yiming-tang-cs commented Dec 21, 2017

This pull request is out of date. I created a new one: #135 . Can I close it?
@khatchad
Copy link
Member

khatchad commented Dec 21, 2017 via email

@yiming-tang-cs yiming-tang-cs deleted the issue_129 branch January 29, 2018 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure

2 participants

@yiming-tang-cs @khatchad