Skip to content

Conversation

@Nyholm
Copy link
Member

@Nyholm Nyholm commented Sep 5, 2019

Im not sure why we limited the versions in #313. But removing a direct dependency in #324 is not a good solution.

I've added back twig/twig with their latest 1.x and 2.x versions.

@XWB XWB merged commit eb40897 into php-translation:master Sep 5, 2019
@Nyholm Nyholm deleted the twig-deps branch September 5, 2019 14:54
@bocharsky-bw
Copy link
Member

@Nyholm Hm, I removed twig/twig in #324 because we also require symfony/twig-bundle which in turn requires twig/twig. I still don't see a value in having twig/twig unless we want to explicitly exclude some Twig versions. Wdyt? //cc @XWB

@Nyholm
Copy link
Member Author

Nyholm commented Sep 5, 2019 via email

@bocharsky-bw
Copy link
Member

Now I see, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants