Try to allow any Twig version #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Easy win, tests passed now! A lot of good changes were merged lately |
welcoMattic approved these changes Jul 26, 2019
| Well done @bocharsky-bw! |
| The issue is still not resolved for people with Twig though (like almost everyone). Removing dependencies is not the solution. |
| @XWB wait, what Twig issue are you talking about? Actually, it wasn't a fix, it was just a partial revert of changes I've done before to make tests green. See #313 (comment) |
| And while tests are green now we can focus on specific problems and improve this bundle step by step. And this is one of such steps |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Let's see if tests pass, but most probably will need to fix some things to make them green with this change