Skip to content

Enhancement: Extract method which ensures result is or converts it to callable #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2019
Merged

Enhancement: Extract method which ensures result is or converts it to callable #43

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2875fd7
Enhancement: Extract method which ensures callable
localheinz Jun 5, 2019
987c5a0
Enhancement: Return early
localheinz Jun 5, 2019
1ad4c09
Enhancement: Use if instead of switch
localheinz Jun 5, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enhancement: Return early
  • Loading branch information
@localheinz
localheinz committed Jun 5, 2019
commit 987c5a0078dde983441f33017c6cf8b33ab78175
12 changes: 3 additions & 9 deletions src/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,26 +141,20 @@ private static function makeCallable($result)
{
switch (true) {
case is_callable($result):
$callable = $result;

break;
return $result;
case $result instanceof ResponseInterface:
$callable = function () use ($result) {
return function () use ($result) {
return $result;
};

break;
case $result instanceof \Exception:
$callable = function () use ($result) {
return function () use ($result) {
throw $result;
};

break;
default:
throw new \InvalidArgumentException('Result must be either a response, an exception, or a callable');
}

return $callable;
}

/**
Expand Down