Skip to content

Enhancement: Extract method which ensures result is or converts it to callable #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2019
Merged

Enhancement: Extract method which ensures result is or converts it to callable #43

merged 3 commits into from
Jun 20, 2019

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Jun 5, 2019 •
edited
Loading

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets n/a
Documentation n/a
License MIT

What's in this PR?

This PR

  • extracts a method which ensures that a result is - or converts it to - a callable
  • returns early
  • uses if instead of switch

Why?

This greatly improves the legibility (in my opinion).
@localheinz localheinz force-pushed the feature/extract branch 3 times, most recently from 8a339eb to 8d03752 Compare June 5, 2019 15:46
dbu
dbu approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes sense to extract this.
@dbu dbu merged commit 79f11ad into php-http:master Jun 20, 2019
@localheinz localheinz deleted the feature/extract branch June 20, 2019 14:29
@localheinz
Copy link
Contributor Author

Thank you, @dbu!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@localheinz @dbu