Support eliding output name; return string or bytes #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pwaller force-pushed the return-strings branch 2 times, most recently from 3bde0b6 to 2c164fa Compare pwaller force-pushed the return-strings branch from 2c164fa to 5bbe52e Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This pull request makes it possible to omit the output filename (or pass
None). In that case, python returns a string for textual formats (e.g, XML, CSV) or bytestring for binary formats (e.g, XLSX).In addition I took a moment to tidy things up a bit and add a test for the
convertcode path.Supercedes #7.