Added support for returning output as string as well #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added support for returning output as string, previously it was dumping output to a file
added import StringIO as install_requires
This reverts commit c5873b3.
aloknayak29 commented Sep 22, 2017
Author
aloknayak29 left a comment
aloknayak29 left a comment There was a problem hiding this comment.
tested today, fixed one bug in the pull request today
Contributor
| Hi! Thanks for your feature request. I took the liberty of re-implementing the suggestion in #8, along with some minor refactoring. (The implementation is cleaner in 0e53acc#diff-de83fe55a9bdd016b327fd18a73b279fR104). To make the XLSX case work, I also return a bytestring instead of a string in that case, as otherwise it would fail with a utf-8 decoding error. Please take a look and let us know if that PR works for you. If it does, I'll merge and publish it under a new release. |
Contributor
| #8 was just merged. Let me know if you encounter any issues with it. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently output is getting dumped in a file. But now output can be returned as a string as well. Modified client's functions like csv,xml etc